Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorials/jokes): throw 403 instead of 401 if user is not the owner #4688

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

chaukhoa97
Copy link
Contributor

@chaukhoa97 chaukhoa97 commented Nov 25, 2022

I think it is more right to be 403 instead of 401 according to MDN.

  • Docs
  • Tests

I think it is more right to be 403 instead of 401 according to MDN.
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

⚠️ No Changeset found

Latest commit: 03dd0ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 25, 2022

Hi @chaukhoa97,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 25, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

docs/tutorials/jokes.md Outdated Show resolved Hide resolved
@machour machour added the docs label Nov 25, 2022
@machour machour changed the title Update the HTTP status code docs(jokes): Use 403 instead of 401 if logged in user is not the owner Nov 25, 2022
@machour machour changed the title docs(jokes): Use 403 instead of 401 if logged in user is not the owner docs(jokes): Use 403 instead of 401 if user is not the owner Nov 25, 2022
@MichaelDeBoey MichaelDeBoey changed the title docs(jokes): Use 403 instead of 401 if user is not the owner docs(tutorials/jokes): throw 403 instead of 401 if user is not the owner Nov 25, 2022
@machour machour merged commit 080e5f5 into remix-run:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants