Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev): add types for importing *.ico files #5430

Merged
merged 4 commits into from
Mar 9, 2023
Merged

fix(remix-dev): add types for importing *.ico files #5430

merged 4 commits into from
Mar 9, 2023

Conversation

TomerAberbach
Copy link
Contributor

Closes: N/A

  • Docs
  • Tests

Testing Strategy: N/A

It seems that *.ico files can be imported to get their paths, but they are not properly typed, so this PR fixes that.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2023

🦋 Changeset detected

Latest commit: 1b1c189

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title Add types for importing *.ico files fix(remix-dev): add types for importing *.ico files Mar 9, 2023
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev March 9, 2023 01:21
@mcansh mcansh merged commit 375ad78 into remix-run:dev Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-375ad78-20230309 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants