Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-eslint-config): don't require display name in root module #5450

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Feb 14, 2023

The root module behaves almost exactly like a layout route, but for the entire site. Like any route module, do not expect or require the default export to have a display name.

Closes: N/A

  • Docs
  • Tests

Testing Strategy:

I tested this by creating a new project with create-remix, removing the name from the default export in root.tsx, and then running eslint. With this patch, there is no warning.

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2023

🦋 Changeset detected

Latest commit: fdbf5e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/eslint-config Patch
create-remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lpsinger lpsinger changed the base branch from main to dev February 14, 2023 06:16
@github-actions
Copy link
Contributor

This PR has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this PR will be automatically closed.

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 17, 2023
@lpsinger
Copy link
Contributor Author

Could I get a PR review for this?

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Apr 17, 2023
@MichaelDeBoey MichaelDeBoey changed the title Remix eslint config no display name in root module feat(remix-eslint-config): don't require display name in root module Apr 17, 2023
@lpsinger lpsinger requested a review from MichaelDeBoey April 18, 2023 01:01
lpsinger and others added 2 commits May 2, 2023 02:40
The root module behaves almost exactly like a layout route, but for
the entire site. Like any route module, do not expect or require
the default export to have a display name.
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@MichaelDeBoey MichaelDeBoey force-pushed the remix-eslint-config-no-display-name-in-root-module branch from 0564b2a to b730b78 Compare May 2, 2023 00:40
@brophdawg11 brophdawg11 merged commit 100d7e3 into remix-run:dev May 2, 2023
@MichaelDeBoey MichaelDeBoey added the awaiting release This issue has been fixed and will be released soon label May 2, 2023
@lpsinger lpsinger deleted the remix-eslint-config-no-display-name-in-root-module branch May 2, 2023 15:57
mcansh added a commit that referenced this pull request May 2, 2023
…5450)

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Co-authored-by: Logan McAnsh <logan@mcan.sh>
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-0e2763f-20230503 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:eslint-config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants