-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-eslint-config): don't require display name in root module #5450
feat(remix-eslint-config): don't require display name in root module #5450
Conversation
🦋 Changeset detectedLatest commit: fdbf5e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this PR will be automatically closed. |
Could I get a PR review for this? |
The root module behaves almost exactly like a layout route, but for the entire site. Like any route module, do not expect or require the default export to have a display name.
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
0564b2a
to
b730b78
Compare
…5450) Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Logan McAnsh <logan@mcan.sh>
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
The root module behaves almost exactly like a layout route, but for the entire site. Like any route module, do not expect or require the default export to have a display name.
Closes: N/A
Testing Strategy:
I tested this by creating a new project with create-remix, removing the name from the default export in root.tsx, and then running eslint. With this patch, there is no warning.