Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove v1 route convention codepaths #5649

Merged
merged 9 commits into from
Mar 23, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 3, 2023

todo:

  • update docs
  • update e2e tests to flat routes
  • tutorials

thoughts:
when removing something from future should we warn when we detect someone has it?

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

🦋 Changeset detected

Latest commit: 012f63f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Major
@remix-run/dev Major
@remix-run/react Major
@remix-run/server-runtime Major
@remix-run/testing Major
create-remix Major
@remix-run/css-bundle Major
@remix-run/cloudflare Major
@remix-run/deno Major
@remix-run/node Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/architect Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/vercel Major
@remix-run/serve Major
@remix-run/eslint-config Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh changed the base branch from dev to v2 March 3, 2023 18:23
@mcansh mcansh marked this pull request as ready for review March 3, 2023 18:36
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Mar 8, 2023
@brophdawg11 brophdawg11 removed the BREAKING CHANGE This change will require a major version bump label Mar 8, 2023
@mcansh mcansh force-pushed the logan/remove-v1-route-convention branch from f44f36a to 4f86104 Compare March 10, 2023 16:34
@mcansh mcansh self-assigned this Mar 14, 2023
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/remove-v1-route-convention branch from 4b67140 to 9bbc4ea Compare March 22, 2023 20:29
[skip ci]

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>

test: remove old test

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh force-pushed the logan/remove-v1-route-convention branch from 813e03b to 9bc0435 Compare March 22, 2023 20:49
[skip ci]

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh merged commit 6ed0879 into v2 Mar 23, 2023
@mcansh mcansh deleted the logan/remove-v1-route-convention branch March 23, 2023 14:34
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Jul 9, 2023
MichaelDeBoey pushed a commit that referenced this pull request Jul 10, 2023
Co-authored-by: Matt Brophy <matt@brophy.org>
@MichaelDeBoey MichaelDeBoey added the v2 Issues related to v2 apis label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants