Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: enable v2_routeConvention config flag by default #5693

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Mar 7, 2023

Once @mcansh's #5606 is released, people will start seeing errors otherwise

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023

⚠️ No Changeset found

Latest commit: 13210e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the enable-v2_routeConvention-flag-by-default-in-templates branch 2 times, most recently from 4a32240 to 2dfbe61 Compare March 7, 2023 22:31
@MichaelDeBoey MichaelDeBoey force-pushed the enable-v2_routeConvention-flag-by-default-in-templates branch from 2dfbe61 to 13210e2 Compare March 8, 2023 00:38
@mcansh mcansh merged commit b74dbae into remix-run:dev Mar 8, 2023
@kiliman
Copy link
Collaborator

kiliman commented Mar 8, 2023

Hmm... I'm surprised that this has been enabled by default in new templates. The v2 convention is not backward-compatible with v1, and many tutorials still use the old convention. Developers will be confused when they try to follow along and wonder why routes aren't working properly.

@MichaelDeBoey MichaelDeBoey deleted the enable-v2_routeConvention-flag-by-default-in-templates branch March 8, 2023 22:27
mcansh added a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants