Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bring back old routing and serverBuildTarget deprecation warnings #5793

Merged
merged 3 commits into from
Mar 14, 2023
Merged

feat: bring back old routing and serverBuildTarget deprecation warnings #5793

merged 3 commits into from
Mar 14, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 14, 2023 •
edited
Loading

This reverts commit de546ae. which brings back deprecation warnings from #5606 and #5624

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e3c4112

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh self-assigned this Mar 14, 2023
@mcansh mcansh merged commit f150bdf into dev Mar 14, 2023
@mcansh mcansh deleted the revert-5790-remove-deprecations branch March 14, 2023 19:31
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 14, 2023
markdalgleish added a commit that referenced this pull request Mar 15, 2023
@markdalgleish
Revert "feat: bring back old routing and serverBuildTarget deprecatio…
3c880cc 
…n warnings (#5793)"

This reverts commit f150bdf.
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-2072f33-20230315 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

fernandojbf pushed a commit to fernandojbf/remix that referenced this pull request Mar 21, 2023
@mcansh @fernandojbf
feat: bring back old routing and serverBuildTarget deprecation warnin…
0083e25 
…gs (remix-run#5793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees

@mcansh mcansh

Labels
awaiting release This issue has been fixed and will be released soon CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcansh @brophdawg11