templates: have loadContext available in handleRequest

[MichaelDeBoey]

Follow-up of #5836

[changeset-bot]

⚠️ No Changeset found

Latest commit: e5aa0c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kiliman]

Any chance we can fix the "typo" before v2 launches?

getLoadContext should be getLoaderContext or, even better, getAppContext.

[brophdawg11]

@kiliman I think getLoadContext is going to change once we add the middleware concepts in v3, so that rename/adjustment should already be on the roadmap for v3

[brophdawg11]

@MichaelDeBoey I don't care enough to push hard for it but I still don't like the _ prefix in our templates. I think if we are going to include the parameter in the templates so the user knows it's available (I'm not 100% sold we even need to since they can find out its availability via TS if they start using getLoadContext), then it should be up to them how to name it if they follow some set of guidelines for naming unused vars. Most of the time I think they'll just delete it but at least they know it's there.

If we keep the _ then they need to rename the var down the road if they decide to leverage it which feels odd.

I also don't like that the _ seems to disable the faded color VSCode adds to unused vars and almost makes it look like it is used?

[github-actions]

🤖 Hello there,

We just published version 1.17.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-45a91e0-20230603 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.17.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.17.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!