Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): cross-module loader change detection #6299

Merged
merged 9 commits into from
May 5, 2023

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented May 3, 2023

TODO

  • move HDR compiler to dev server flow
  • rip out HMR onLoader code from JS subcompiler
  • remove HMR stuff from manifest
  • compute revalidate HMR field from HDR results
  • Enable commented out check at end of hmr-test and hmr-log-test
  • MDX
  • pass updated ctx thru onBuildStart
  • changelog

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

🦋 Changeset detected

Latest commit: ba12063

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
@remix-run/react Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/testing Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori force-pushed the pedro/cross-module-loader-change-detection branch from 1bcce40 to 8f7456a Compare May 4, 2023 18:38
@pcattori pcattori force-pushed the pedro/cross-module-loader-change-detection branch 2 times, most recently from 7bdcb9c to fffc5f5 Compare May 4, 2023 20:49
@pcattori pcattori requested a review from jacob-ebey May 4, 2023 22:15
@pcattori pcattori changed the title wip feat(dev): cross-module loader change detection May 4, 2023
@pcattori pcattori marked this pull request as ready for review May 4, 2023 22:21
@pcattori pcattori merged commit f5ef1ac into dev May 5, 2023
@pcattori pcattori deleted the pedro/cross-module-loader-change-detection branch May 5, 2023 00:58
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-6e23fcf-20230505 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants