Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-vercel)!: remove Vercel adapter #7035

Closed

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Aug 2, 2023

Template was removed by #6784

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: de80564

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey added the v2 Issues related to v2 apis label Aug 2, 2023
@MichaelDeBoey MichaelDeBoey force-pushed the remove-vercel-adapter branch 3 times, most recently from e109421 to d5bbe0f Compare August 3, 2023 15:48
@brophdawg11 brophdawg11 removed their request for review August 4, 2023 11:50
@MichaelDeBoey MichaelDeBoey force-pushed the remove-vercel-adapter branch 3 times, most recently from e957b39 to 50ae3a9 Compare August 7, 2023 19:49
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Aug 7, 2023
@ryanflorence
Copy link
Member

merged manually, though I probably should have run the tests first after the dev rebase 🫣

MichaelDeBoey added a commit to MichaelDeBoey/remix that referenced this pull request Aug 8, 2023
@MichaelDeBoey
Copy link
Member Author

@ryanflorence I think you probably should have merged this PR via GitHub so the reference to this PR was kept in the commit message (and probably also in Changeset)

@brophdawg11
Copy link
Contributor

We can just add them directly to the changeset - 002ed42

@brophdawg11
Copy link
Contributor

For future reference, the work in this PR got merged directly to dev - here's the commit: a07ae17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump CLA Signed v2 Issues related to v2 apis
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants