fix(remix-dev/vite): set same config.mode for child compiler

[hi-ogawa]

Closes: #7901

I wrote a longer explanation here while investigating it #7901 (comment)
This specific issue of mdx rollup plugin is due to that single plugin instance's hook { config(config, env) => .. } is run twice with different env.mode and child compiler's config hook runs later and it overwrites plugin's internal state which then affects parent compiler's transform https://github.com/mdx-js/mdx/blob/efff74e48aec9286c62185bf04f7b8aa72e07bd6/packages/rollup/lib/index.js#L76-L82

Note that this change only tries to align env.mode between parent and child compilers.
env.command is still inconsistent during vite build where parent has command = "build" while child has command = "serve".
So, this change probably doesn't help more complicated case and thus this is nothing but quick workaround for mdx plugin.
Nonetheless, starting with having consistent env.mode won't probably do any harm, so that's my main rational for this PR.

• Docs
• Tests

Testing Strategy:

Confirmed this fix the reproduction from #7901 by patch-package @remix-run/dev with a following patch:

diff --git a/node_modules/@remix-run/dev/dist/vite/plugin.js b/node_modules/@remix-run/dev/dist/vite/plugin.js
index 3f025ab..bcbad86 100644
--- a/node_modules/@remix-run/dev/dist/vite/plugin.js
+++ b/node_modules/@remix-run/dev/dist/vite/plugin.js
@@ -340,6 +340,7 @@ const remixVitePlugin = (options = {}) => {
       await esModuleLexer.init;
       viteChildCompiler = await vite.createServer({
         ...viteUserConfig,
+        mode: viteConfig.mode,
         server: {
           ...viteUserConfig.server,
           // when parent compiler runs in middleware mode to support

I wasn't sure if this PR warrants new test to verify the behavior.
Please let me know if it's desired to add test (for example, integration test with @mdx/rollup for both dev/build, or using dummy plugin like in #7901 (comment) to verify this specific env.mode behavior).

[changeset-bot]

🦋 Changeset detected

Latest commit: 0a30c7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/dev	Patch
create-remix	Patch
remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[markdalgleish]

Thanks for the PR! I've added some tests too. I went with MDX-specific tests for this so that we're also testing MDX can be used as routes.

[hi-ogawa]

Thanks for adding tests. Looks good!.

[github-actions]

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!