Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev/vite): add buildDirectory and manifest options #8575

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

markdalgleish
Copy link
Member

This PR makes a few interrelated changes:

  • To future proof the server bundles bundles.json concept, the build/server/bundles.json file has been replaced with a more general build/manifest.json file. This allows us to add more build metadata in the future without having multiple manifest files on disk.
  • The build manifest on disk feels like noise for most consumers. So, similar to many other build tools (including Vite) we don't write a manifest by default.
  • In order to know where to write the build manifest to, we need to know where the overall build root is. We currently do not have this knowledge since the server and client build output paths are independently configurable. To address this, we're now replacing the separate assetsBuildDirectory and serverBuildDirectories with a single buildDirectory option. This streamlines and simplifies a bunch of things which is a nice win by itself.
  • The remixConfig and buildManifest properties have been more clearly separated in the adapter buildEnd hook. This is not a breaking change since the feature hasn't been released yet.

Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 6ea1120

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit 10fcf5b into dev Jan 22, 2024
9 checks passed
@pcattori pcattori deleted the markdalgleish/vite-build-directory-and-manifest branch January 22, 2024 17:37
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 22, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.6.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Feb 1, 2024

🤖 Hello there,

We just published version 2.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants