vite: no livereload, scripts injects hmr runtime instead #8636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6202840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
force-pushed
the
pedro/scripts-devonly
branch
3 times, most recently
from
d1d6443
to
945f177
Compare
pcattori
force-pushed
the
pedro/scripts-devonly
branch
from
945f177
to
b780a0a
Compare
Comment on lines
-1293
to
-1339
| { | ||
| name: "remix-remix-react-proxy", | ||
| resolveId(id) { | ||
| if (id === remixReactProxyId) { | ||
| return VirtualModule.resolve(remixReactProxyId); | ||
| } | ||
| }, | ||
| transform(code, id) { | ||
| // Don't transform the proxy itself, otherwise it will import itself | ||
| if (id === VirtualModule.resolve(remixReactProxyId)) { | ||
| return; | ||
| } | ||
|
|
||
| let hasLiveReloadHints = | ||
| code.includes("LiveReload") && code.includes("@remix-run/react"); | ||
|
|
||
| // Don't transform files that don't need the proxy | ||
| if (!hasLiveReloadHints) { | ||
| return; | ||
| } | ||
|
|
||
| // Rewrite imports to use the proxy | ||
| return replaceImportSpecifier({ | ||
| code, | ||
| specifier: "@remix-run/react", | ||
| replaceWith: remixReactProxyId, | ||
| }); | ||
| }, | ||
| load(id) { | ||
| if (id === VirtualModule.resolve(remixReactProxyId)) { | ||
| // TODO: ensure react refresh is initialized before `<Scripts />` | ||
| return [ | ||
| 'import { createElement } from "react";', | ||
| 'export * from "@remix-run/react";', | ||
| `export const LiveReload = ${ | ||
| viteCommand !== "serve" | ||
| } ? () => null : `, | ||
| '({ nonce = undefined }) => createElement("script", {', | ||
| " nonce,", | ||
| " dangerouslySetInnerHTML: { ", | ||
| " __html: `window.__remixLiveReloadEnabled = true`", | ||
| " }", | ||
| "});", | ||
| ].join("\n"); | ||
| } | ||
| }, | ||
| }, |
markdalgleish
approved these changes
Jan 31, 2024
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy compiler works
Vite w/
<LiveReload />warnsVite w/o
<LiveReload />works