-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure remix react re-exports everything from react-router-dom #8929
Conversation
🦋 Changeset detectedLatest commit: 0635f97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
let nonReExportedKeys = new Set([ | ||
// Internal error used by Remix | ||
"AbortedDeferredError", | ||
// Remix manages the router for you, so we don't re-export these | ||
"BrowserRouter", | ||
"HashRouter", | ||
"MemoryRouter", | ||
"Router", | ||
"RouterProvider", | ||
"createBrowserRouter", | ||
"createHashRouter", | ||
"createMemoryRouter", | ||
// Don't re-export unsafe APIs | ||
"unstable_HistoryRouter", | ||
"UNSAFE_DataRouterContext", | ||
"UNSAFE_DataRouterStateContext", | ||
"UNSAFE_FetchersContext", | ||
"UNSAFE_LocationContext", | ||
"UNSAFE_NavigationContext", | ||
"UNSAFE_RouteContext", | ||
"UNSAFE_ViewTransitionContext", | ||
"UNSAFE_useRouteId", | ||
"UNSAFE_useScrollRestoration", | ||
]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't re-export these keys for noted reasons
"Await", // types | ||
"Link", // remix-specific prefetching loigc | ||
"NavLink", // remix-specific prefetching loigc | ||
"ScrollRestoration", // remix-specific SSR restoration logic | ||
"defer", // types | ||
"json", // types | ||
"redirect", // types | ||
"redirectDocument", // types | ||
"useActionData", // types | ||
"useFetcher", // types | ||
"useLoaderData", // types | ||
"useMatches", // types | ||
"useRouteLoaderData", // types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remix should have these exports but it has to maintain it's own wrappers so ensure it's exported but not identical to the RR version
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This ensures SPA mode migrations are as smooth as possible and shouldn't need
react-router-dom
as a dependency