Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlling the locale: documentation + examples #1339

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Controlling the locale: documentation + examples #1339

merged 2 commits into from
Mar 4, 2021

Conversation

deining
Copy link
Contributor

@deining deining commented Mar 4, 2021

This PR adds a new chapter 19.6 Controlling the locale to the manual, as proposed in #1326.
Also sample files are added to the picocli-examples module.

Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thank you so much!
I noticed some minor things, happy to merge otherwise.

docs/index.adoc Outdated Show resolved Hide resolved
docs/index.adoc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1339 (3b20e2c) into master (9032c04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1339   +/-   ##
=========================================
  Coverage     93.76%   93.76%           
  Complexity      474      474           
=========================================
  Files             2        2           
  Lines          6961     6961           
  Branches       1869     1869           
=========================================
  Hits           6527     6527           
  Misses          147      147           
  Partials        287      287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9032c04...e939158. Read the comment docs.

@deining deining requested a review from remkop March 4, 2021 11:30
@remkop remkop merged commit 0c5a971 into remkop:master Mar 4, 2021
@remkop
Copy link
Owner

remkop commented Mar 4, 2021

Merged. Thank you very much! I will update the release notes tomorrow. Bedtime for me now. :-)

@deining deining deleted the locale_control branch March 7, 2021 18:16
MarkoMackic pushed a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
MarkoMackic added a commit to MarkoMackic/picocli that referenced this pull request Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants