Fix #1369 by upgrading jline3 to version 3.19.0 #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
=========================================
Coverage 93.75% 93.75%
Complexity 474 474
=========================================
Files 2 2
Lines 6968 6968
Branches 1872 1872
=========================================
Hits 6533 6533
Misses 147 147
Partials 288 288 Continue to review full report at Codecov.
|
remkop
added
type: dependency 📚
theme: shell
remkop
added a commit
that referenced
this pull request
May 5, 2021
|
Merged. Thank you for the contribution! |
MarkoMackic
pushed a commit
to MarkoMackic/picocli
that referenced
this pull request
Oct 17, 2021
…"ReadConsoleInputW failed: Incorrect function" error
MarkoMackic
added a commit
to MarkoMackic/picocli
that referenced
this pull request
Oct 17, 2021
…o avoid "ReadConsoleInputW failed: Incorrect function" error" This reverts commit 24ef290.
MarkoMackic
added a commit
to MarkoMackic/picocli
that referenced
this pull request
Oct 17, 2021
…o avoid "ReadConsoleInputW failed: Incorrect function" error" This reverts commit 24ef290.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jline3 version 3.18 causes several problems in combination with Jansi 2.3.2. Solution is to upgrade jline3 to 3.19