[#1388] Fix subcommand aliases autocomplete regression #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The subcommands now get their name inerpolated in Not sure it is the correct solution - but all tests now pass. |
|
Still need some changes, not ready for merge yet. |
Okay, understood. Thank you for looking at this! |
Fixed the issue now. Edit: The codeclimate issues seem to be unrelated. |
NewbieOrange
force-pushed
the
master
branch
from
3fce00c to
b52b1c3
Compare
|
Apologies for the long wait. I will try to look at this soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix #1388 regression, and I have added a new test for the issue.
However, this cause #1352
testIssue1352_SubcommandNameResourceBundleto fail, which seemed to be caused bydescriptor.commandNameis${project.cli.command}, and it's fromcommandLine.getSubcommands().entrySet().?.getKey(), indicating there might be some issue in resource bundle propagation for subcommands.@remkop any thoughts?