-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #2074 AutoComplete with jline3 is showing hidden values #2075
Conversation
This fixed my issue on the artemis shell / jline3 integration. I'm not sure yet how to add a test for this (still looking) meanwhile this serves as a discussion starter. |
@remkop I tried to write a test :) .. but I don't understand how this dejavu test works, and what you expect on these spawned tests. I supposed they are emulating an auto-completion and terminal .. but I couldn't progress much further without some guidance. It seems though this should be an easy fix for someone knowledgeable about this codebase.. if you could handle this issue.. or someone else already knowledgeable here? |
@clebertsuconic Thanks for raising this and thanks for the pull request! Looks good. About the tests, the dejagnu stuff is mostly for testing bash completion and it’s a bit of a learning curve… |
@remkop how often you make releases? just planning the artemis release after this. (I could also extend and fix in the usage for now).. just for my planning. thanks. |
Merged. Thank you for the contribution! |
@remkop thank you so much. I hate to be one of those guys asking for a release? :) but how far is a release? :) |
I will probably try to fix some more items that are currently in scope for 4.7.5 before doing a release. Especially the bugs. I don't have time lines, sorry. |
No description provided.