Bump JLine to 3.14.1 and fix #969 #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working in Picocli Shell JLine3?
remkop
added
theme: auto-completion
|
@mattirn Merged into master. Thank you for the contribution!
Do you mean JLine 3.14.1, or another future JLine release? |
|
JLine 3.14.2 + small modification in picocli-shell-jline3. I have already modified JLine and tested also picocli-shell-jline3 using JLine 3.14.2-SNAPSHOT |
|
@mattirn Understood. Thanks for the quick response! Looking forward to it! |
remkop
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually fix #969 only the command tab completion part.
Method
commandDescription()still fails to return sub-command descriptions. In order to fix this we need next JLine release.