Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Svelte support #23

Closed
bdougherty opened this issue Mar 2, 2019 · 9 comments · Fixed by #100
Closed

Add Svelte support #23

bdougherty opened this issue Mar 2, 2019 · 9 comments · Fixed by #100
Labels
hacktoberfest help wanted Extra attention is needed

Comments

@bdougherty
Copy link

Would be cool to have Svelte support. Happy to attempt a PR once 3.0 is final, assuming it will be accepted.

@mblarsen
Copy link

mblarsen commented Mar 6, 2019

assuming it will be accepted

That depends on your PR as well :)

Go ahead. I would like Svelte (v3) support as well.

@asadm
Copy link
Contributor

asadm commented Mar 6, 2019

I would love to add support. One concerns:
Zero decides which handler/parser to send the file to based on the file extension ie. .jsx=> handler-react, .js=>handler-js etc. I wonder how we can differentiate between various js frameworks all saved as .js file. Maybe perform some AST?
This problem applies to supporting any other JS frameworks too.

@bdougherty
Copy link
Author

bdougherty commented Mar 7, 2019

@mblarsen ha yeah, I meant more if the project is open to adding additional framework support.

@asadm Svelte is going to officially use the .svelte extension soon (sveltejs/svelte#2067), so I don't think that will be an issue here. Previously .html was used, but I think it's reasonable to require .svelte for zero.

@asadm
Copy link
Contributor

asadm commented Mar 7, 2019

Great. I am happy to assist with this once the extension is supported.

@LukasOchmann
Copy link

What about an first-line comment like //react or //svelte ...and as a fallback using the file extension.
Also an //ignore would be possible this way.

@brucou
Copy link

brucou commented Apr 30, 2019

Svelte 3 is released!!

@asadm
Copy link
Contributor

asadm commented Apr 30, 2019

Awesome! I will look into this soon if no one else does.

@asadm asadm added the help wanted Extra attention is needed label Aug 16, 2019
@asadm asadm mentioned this issue Nov 21, 2019
3 tasks
@asadm
Copy link
Contributor

asadm commented Nov 22, 2019

I just finished Svelte 3 support for zero. Docs. It's live in the latest stable!

@brucou
Copy link

brucou commented Nov 22, 2019

That's awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants