Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file extension to .svelte #2067

Closed
7 of 9 tasks
Rich-Harris opened this issue Feb 7, 2019 · 2 comments
Closed
7 of 9 tasks

Change file extension to .svelte #2067

Rich-Harris opened this issue Feb 7, 2019 · 2 comments
Labels

Comments

@Rich-Harris
Copy link
Member

Rich-Harris commented Feb 7, 2019

The people have spoken — we should use the .svelte file extension for Svelte components.

  • update tests
  • update Sapper to recognise .svelte files OOTB
  • update rollup-plugin-svelte, svelte-loader etc rollup-plugin-svelte already supports it, svelte-loader doesn't know about extensions (that goes in the webpack config itself)
  • update sveltejs/template, sveltejs/template-webpack, sveltejs/sapper-template
  • update docs (including adding instructions for adding the VSCode extension, or for associating .svelte with HTML)
  • create extensions for Sublime etc?
  • update REPL
  • TextMate grammar (this could be a good starting point, though it's Svelte 2 and will need some tweaks)
  • probably a bunch of other stuff
kugaevsky added a commit to kugaevsky/rouge that referenced this issue Feb 8, 2019
[Svelte framework](https://svelte.technology/) will use `*.svelte` extension for its component files —  sveltejs/svelte#2067. It would be nice to add highlighting for it.
This was referenced Feb 8, 2019
Rich-Harris added a commit that referenced this issue Feb 9, 2019
@scorsi
Copy link

scorsi commented Apr 23, 2019

Just to say that Svelte isn't recognised yet by GitHub as a language, but someone did a PR to the GitHub's Linguist repository (I wanted to do it before I saw someone already did it) to add the Svelte support, here: github-linguist/linguist#4504. So it may be supported in some times in Github, hourra ! 🎉

@Conduitry Conduitry added the meta label Jul 28, 2019
@antony
Copy link
Member

antony commented Dec 24, 2019

A quick look through the docs tells me that the conversion from .html to .svelte is complete, and the PR has been merged into linguist 🎉 and the remaining items here are:

[ ] Add instructions for IDE setup / sublime / intellij (there is an open PR for some of this, but I think it needs a PR/issue of its own if somebody is willing to do this for each IDE)
[ ] A bunch of other stuff which really isn't actionable.

On this basis I think it's safe to close this stale issue and let these issues come out of the woodwork on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants