Refactor synced GET function #1135
Merged
+15
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the code. Aside from being more readable, this fixes a problem with the UglifyJS compressor destroying the code by restructuring it wrong. closes #1133
ghost
assigned 
galfert
reviewed
Oct 31, 2018
| context.remote.connected && context.remote.online) { | ||
| return 2 * context.getSyncInterval(); | ||
| } else { | ||
| log('Not setting default maxAge, because remote is offline or not connected'); |
There was a problem hiding this comment.
The log in this function is kind of misleading, as the function itself is not setting anything but just returning a value.
There was a problem hiding this comment.
The function is only used one time in the code below. It's never used for not setting the default max age. So I think it's OK in this case.
|
LGTM 👍 |
|
👍 |
|
Thanks again for this. Any chance of a new release with it? |
|
Yup, sometime this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the code. Aside from being more readable, this fixes a problem with the UglifyJS compressor destroying the code by restructuring it wrong.
closes #1133