Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-Exec] Add logging levels to runtime library #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZippeyKeys12
Copy link
Collaborator

@ZippeyKeys12 ZippeyKeys12 commented Sep 30, 2024

In the case of random testing, I don't think we want all of these logs, except for a failing input.

Instead I think we want to:

  • disable logging
  • test many random inputs
  • if we find a failing one
    • re-enable logging at the error level
    • rerun the failing input
  • we allow the user to re-run it again with the full logs

In the case of random testing, we don't want all of these logs, except for a failing input. We can disable logging, test many inputs and if we find a failing one, we re-enable logging and rerun that input.
@rbanerjee20
Copy link
Contributor

This looks good, but I think we do want a debug level where we can see all the print statements as we are currently seeing them, which we would probably want to be configurable as a CLI option. I think this would be quite a bit more work though, since connecting up parts of the runtime library with the generated output seems less straightforward than just modifying the runtime library directly

@ZippeyKeys12
Copy link
Collaborator Author

I'm not sure I understand, the default logging level CN_LOGGING_INFO shows all the current print statements. Do you mean also exposing the ability to change the logging level via the cn instrument command? If so, that should be easy to do, I can add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants