Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates update-notifier package version (won't merge - leaving open for others not to send another PR) #2034

Closed
wants to merge 1 commit into from

Conversation

sergey-shpak
Copy link

since update-notifier@5.1.0 is vulnerable, updated to the latest version

@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for nodemon ready!

Name Link
🔨 Latest commit 449872e
🔍 Latest deploy log https://app.netlify.com/sites/nodemon/deploys/62b5d60c7eb31e0009ac1f33
😎 Deploy Preview https://deploy-preview-2034--nodemon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@remy
Copy link
Owner

remy commented Jun 24, 2022

This PR breaks for users.

See other issues (probably closed because it was reverted).

@remy remy changed the title Updates update-notifier package version Updates update-notifier package version (won't merge - leaving open for others not to send another PR) Jun 24, 2022
@sergey-shpak
Copy link
Author

sergey-shpak commented Jun 25, 2022

@remy

This PR breaks for users.

what do you mean? Could you please share issues?

I've tried to install nodemon directly from my branch and it works as expected.

@remy
Copy link
Owner

remy commented Jun 25, 2022

Just take a look at the recently closed issues on GitHub for info. Sure, it worked for me too, but that's not how we support good software.

@remy
Copy link
Owner

remy commented Jun 28, 2022

Closing in favour of #2033

@remy remy closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants