Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete service subcommand #64

Merged

Conversation

llimllib
Copy link
Contributor

@llimllib llimllib commented Aug 3, 2023

Adds support for deleting a service. Here's an example of it in action:

$ ./bin/render services list
id                       name                type        serviceDetails.env slug                serviceDetails.numInstances
crn-cj5s2dicn0vc73fv4rlh test-service-delete cron_job    image              test-service-delete                            
srv-cisrtch5rnujejodpfq1 metrics-test-stage  web_service image              metrics-test-stage  1                          
srv-cisrtch5rnujejodpfqh metrics-test-prod   web_service image              metrics-test-prod   1                          
srv-chnpupo2qv207f2k374h readme-next         web_service docker             readme-next         1                          

$ ./bin/render services delete --id crn-cj5s2dicn0vc73fv4rlh

$ ./bin/render services list
id                       name               type        serviceDetails.env slug               serviceDetails.numInstances
srv-cisrtch5rnujejodpfq1 metrics-test-stage web_service image              metrics-test-stage 1                          
srv-cisrtch5rnujejodpfqh metrics-test-prod  web_service image              metrics-test-prod  1                          
srv-chnpupo2qv207f2k374h readme-next        web_service docker             readme-next        1
  • It doesn't look like any of the other commands are tested, so there are no tests
  • I couldn't figure out what formatter you are using so the code may not be formatted according to your project's style
    • I'm happy to fix that if you can help me out

@llimllib
Copy link
Contributor Author

llimllib commented Aug 16, 2023

@robdimarco-render 2 questions:

  • Any interest in this PR?
  • Is this CLI an ongoing concern? It seems to be abandoned

@robdimarco-render robdimarco-render merged commit 79dad1b into render-oss:main Aug 16, 2023
4 checks passed
@robdimarco-render
Copy link
Contributor

Thanks for the submission.

Currently, the CLI is being maintained. However, new development on it has been a lower priority for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants