forked from aws/amazon-freertos
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CONFIRMED] RX65N RSK (Ether) with no tests errors.
[UPDATED] RX65N RSK (Ether) aws_pkcs11_pal.c data storing to FLASH ROM. Signed-off-by: SheltyDog <hiroki.ishiguro.fv@renesas.com>
- Loading branch information
1 parent
6379d06
commit 7e03502
Showing
6 changed files
with
352 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
7e03502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PKCS11_PAL_FindObject, can we modify this to check if there is a valid object stored behind the handle before returning handle value?
7e03502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will modify this.
7e03502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into these comments!
One more question - if the device was previously provisioned (and then power cycled), and no call to PKCS11_PAL_SaveObject is made, is the RAM (pkcs_control_block_data_image) ever restored with the values from flash?
If this is not the case, one option that is available is to initialize the RAM during the C_Initialize call by doing an override of the default C_Initialize (by defining pkcs11configC_INITIALIZE_ALT located in aws_pkcs11_config.h). Note that C_Initialize would also still need to call prvMbedTLS_Initialize
7e03502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, your comment is quite useful for me. Extremely thanks.
Your pointed out is correct. I will add override C_Initialize.
7e03502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified this at: 5c7ad20
7e03502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this feature at: 69049fa
7e03502
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed correctly behavior with power cycled in actual experiment at: 4f84ec9