Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get major updates that pass tests #32

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HonkingGoose
Copy link
Contributor

Changes:

  • Create a config that will get us "easy major updates" automatically

Context:

Right now we have to click on major type updates on our Dependency Dashboard to try out the update on a branch with tests. This means that we won't know if any major type update is actually an easy merge until we do manual work to get the update PR from Renovate.

I think we can improve our workflow by letting Renovate:

  1. Create a branch for major type updates, and do not open PR yet
  2. GitHub runs tests on the branch
  3. If test pass -> open PR for major update (probably an easy merge)
  4. If tests fail -> do not open PR, wait for a maintainer to "force" the PR via the Dependency Dashboard.

@rarkins
Copy link
Contributor

rarkins commented Dec 15, 2021

I'm not sure we want major PRs within hours of them being released though, even if they pass. Before this we probably need the new "majorStreamDelay" feature (sorry, forget which name I proposed) inside Renovate so that we can wait at least a week or two

@viceice
Copy link
Member

viceice commented Dec 15, 2021

@rarkins Yes, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants