fix(npm): remove invalid extractedConstraints (#24465)

renovatebot · Sep 18, 2023 · 1721e8c · 1721e8c
1 parent 6282904
commit 1721e8c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/lib/modules/manager/npm/extract/__snapshots__/index.spec.ts.snap b/lib/modules/manager/npm/extract/__snapshots__/index.spec.ts.snap
@@ -131,7 +131,6 @@ exports[`modules/manager/npm/extract/index .extractPackageFile() extracts engine
     "npm": "^8.0.0",
     "pnpm": "^1.2.0",
     "vscode": ">=1.49.3",
-    "yarn": "disabled",
   },
   "managerData": {
     "hasPackageManager": false,

diff --git a/lib/modules/manager/npm/extract/index.spec.ts b/lib/modules/manager/npm/extract/index.spec.ts
@@ -444,7 +444,6 @@ describe('modules/manager/npm/extract/index', () => {
           npm: '^8.0.0',
           pnpm: '^1.2.0',
           vscode: '>=1.49.3',
-          yarn: 'disabled',
         },
         deps: [
           { depName: 'angular', currentValue: '1.6.0' },

diff --git a/lib/modules/manager/npm/extract/index.ts b/lib/modules/manager/npm/extract/index.ts
@@ -501,6 +501,15 @@ export async function extractPackageFile(
     }
   }
 
+  for (const [constraintName, constaintValue] of Object.entries(
+    extractedConstraints
+  )) {
+    // delete any extracted constraints which aren't valid semver ranges
+    if (!isValid(constaintValue)) {
+      delete extractedConstraints[constraintName];
+    }
+  }
+
   return {
     deps,
     packageFileVersion,