(git): gerrit and codecommit git credentials are not added when updating cargo packages

[Shegox]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

38.21.1

Please tell us more about your question or problem

Renovate automatically adds credentials for known git registries when performing artifact updates for cargo, golang and more through getGitEnvironmentVariables.
This currently doesn't include gerrit. The same problem should occur for codecommit, but I wasn't able to test that.

The underlaying problem is that we use the standardGitAllowedHostTypes array to determine which hostTypes support git and this subset of hostTypes and is missing the two recently added gerrit and codecommit platforms as well as local (which probably isn't so important).

renovate/lib/util/git/auth.ts

Lines 18 to 26 in f3ef173

	const standardGitAllowedHostTypes = [
	// All known git platforms
	'azure',
	'bitbucket',
	'bitbucket-server',
	'gitea',
	'github',
	'gitlab',
	] satisfies PlatformId[];

Proposed solution

• We can just add gerrit and codecommit to the list
• I would propose that we just use the full list of supported platformIds from

  renovate/lib/constants/platforms.ts

  Lines 1 to 10 in d560187

  	export type PlatformId =
  	| 'azure'
  	| 'codecommit'
  	| 'bitbucket'
  	| 'bitbucket-server'
  	| 'gerrit'
  	| 'gitea'
  	| 'github'
  	| 'gitlab'
  	| 'local';

  and make them available as values and drop the double defined standardGitAllowedHostTypes. I implemented this via chore(constants): export PLATFORM_HOST_TYPES constant as value #30642 and chore(git): use PLATFORM_HOST_TYPES as supported git hosts for gitAllowedHostTypes #30643.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[Shegox]

Resolved in 38.21.4 via #30642 and #30643.