Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize file logging to more early #14705

Closed
viceice opened this issue Mar 17, 2022 · 9 comments · Fixed by #28104
Closed

Initialize file logging to more early #14705

viceice opened this issue Mar 17, 2022 · 9 comments · Fixed by #28104
Assignees
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality) v38

Comments

@viceice
Copy link
Member

viceice commented Mar 17, 2022

What would you like Renovate to be able to do?

Currently we miss a lot of log messages on file logging here

// Add file logger
// istanbul ignore if
if (config.logFile) {
logger.debug(
`Enabling ${config.logFileLevel} logging to ${config.logFile}`
);
await ensureDir(getSubDirectory(config.logFile));
addStream({
name: 'logfile',
path: config.logFile,
level: config.logFileLevel,
});
}

I like to remove the config oiptions and initialize it via env only, like we do for LOG_LEVEL.

If you have any ideas on how this should be implemented, please tell us here.

Sure, do it like we do for LOG_LEVEL. Deprecate old option and remove in a future major change.

Is this a feature you are interested in implementing yourself?

Yes

@viceice viceice added type:feature Feature (new functionality) status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:config Related to config capabilities and presets and removed priority-5-triage labels Mar 17, 2022
@rarkins
Copy link
Collaborator

rarkins commented Mar 18, 2022

Which options specifically? e.g. LOG_FILE ?

@viceice
Copy link
Member Author

viceice commented Mar 18, 2022

Yes LOG_FILE and LOG_FILE_LEVEL.

@rarkins rarkins added status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Oct 1, 2023
@viceice
Copy link
Member Author

viceice commented Mar 19, 2024

@zharinov @RahulGautamSingh do you have some time for it?

should be easy to implement

@RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh do you have some time for it?

I can try it this week

@rarkins
Copy link
Collaborator

rarkins commented Apr 10, 2024

@viceice should we drop support of logFile and logFileLevel and target this for v38?

@viceice
Copy link
Member Author

viceice commented Apr 10, 2024

sounds good to me

@RahulGautamSingh
Copy link
Collaborator

One more PR is needed to complete this one. logFile and logFileContext should be dropped in it.

@viceice
Copy link
Member Author

viceice commented May 14, 2024

yes, should be dropped in v38

rarkins pushed a commit that referenced this issue Jul 25, 2024
Closes #14705

BREAKING CHANGE: File logging must now be set via env and not in config.js
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality) v38
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants