Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(managers/circleci): add registryAliases support to circleci manager #32945

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

evilensky
Copy link
Contributor

Changes

This intends to add support for registryAliases to the circleci manager.

Context

We use an ECR repository that is fronted by a proxy host. The proxy host is responsible for authentication. The vast majority of our image names reference the proxy host repository.

We are now starting to use some of the same images, but addressed through their non-proxied names. this is required for circleci to make use of OIDC for auth to ECR.

The below example should work for the circleci manager.

    "registryAliases":
    {
        "123456789012.dkr.ecr.us-west-2.amazonaws.com": "docker-registry.our-project.io"
    },

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@evilensky evilensky changed the title add registryAliases support to circleci manager feat(managers/circleci): add registryAliases support to circleci manager Dec 6, 2024
@evilensky evilensky force-pushed the registryAliases_circleci branch from 7a2b07d to c061ffd Compare December 6, 2024 17:47
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/circleci/extract.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
@rarkins rarkins enabled auto-merge December 7, 2024 06:52
rarkins
rarkins previously approved these changes Dec 7, 2024
auto-merge was automatically disabled December 7, 2024 18:12

Head branch was pushed to by a user without write access

@evilensky evilensky requested review from viceice and rarkins December 9, 2024 03:52
@viceice viceice added this pull request to the merge queue Dec 9, 2024
Merged via the queue into renovatebot:main with commit 914ab95 Dec 9, 2024
42 of 58 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@evilensky evilensky deleted the registryAliases_circleci branch December 9, 2024 15:35
SuperSandro2000 added a commit to SuperSandro2000/renovate that referenced this pull request Dec 10, 2024
* upstream/main: (57 commits)
  feat(mix): handle hex package aliases (renovatebot#32984)
  feat(preset): Add modules to Jackson monorepo group (renovatebot#32997)
  docs(nuget): add info about nested nuget ignorePaths (renovatebot#33020)
  chore(deps): update github/codeql-action action to v3.27.7 (renovatebot#33018)
  docs: remove app secrets deprecation date (renovatebot#33010)
  docs: added Renovate Version info to Mend-hosted Apps config page (renovatebot#32917)
  feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.18.0 (renovatebot#33002)
  chore(deps): update dependency type-fest to v4.30.0 (renovatebot#33001)
  refactor(maven): Unified result type for http fetch (renovatebot#32813)
  feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.17.0 (renovatebot#32993)
  refactor: Flatten package lookup queue (renovatebot#32930)
  chore(deps): update dependency pdm to v2.22.0 (renovatebot#32990)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.2.2 (renovatebot#32989)
  chore(deps): update dependency renovatebot/github-action to v41.0.6 (renovatebot#32986)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.2.2 (renovatebot#32987)
  feat(managers/circleci): add registryAliases support to circleci manager (renovatebot#32945)
  refactor: Rename manager result type to `MaybePromise` (renovatebot#32977)
  chore(deps): lock file maintenance (renovatebot#32982)
  docs: update references to renovate/renovate (renovatebot#32981)
  chore(deps): update dependency type-fest to v4.29.1 (renovatebot#32980)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants