-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(managers/circleci): add registryAliases support to circleci manager #32945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilensky
changed the title
add registryAliases support to circleci manager
feat(managers/circleci): add registryAliases support to circleci manager
Dec 6, 2024
evilensky
force-pushed
the
registryAliases_circleci
branch
from
December 6, 2024 17:47
7a2b07d
to
c061ffd
Compare
viceice
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
rarkins
previously approved these changes
Dec 7, 2024
auto-merge was automatically disabled
December 7, 2024 18:12
Head branch was pushed to by a user without write access
rarkins
approved these changes
Dec 9, 2024
viceice
approved these changes
Dec 9, 2024
🎉 This PR is included in version 39.58.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SuperSandro2000
added a commit
to SuperSandro2000/renovate
that referenced
this pull request
Dec 10, 2024
* upstream/main: (57 commits) feat(mix): handle hex package aliases (renovatebot#32984) feat(preset): Add modules to Jackson monorepo group (renovatebot#32997) docs(nuget): add info about nested nuget ignorePaths (renovatebot#33020) chore(deps): update github/codeql-action action to v3.27.7 (renovatebot#33018) docs: remove app secrets deprecation date (renovatebot#33010) docs: added Renovate Version info to Mend-hosted Apps config page (renovatebot#32917) feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.18.0 (renovatebot#33002) chore(deps): update dependency type-fest to v4.30.0 (renovatebot#33001) refactor(maven): Unified result type for http fetch (renovatebot#32813) feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.17.0 (renovatebot#32993) refactor: Flatten package lookup queue (renovatebot#32930) chore(deps): update dependency pdm to v2.22.0 (renovatebot#32990) chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.2.2 (renovatebot#32989) chore(deps): update dependency renovatebot/github-action to v41.0.6 (renovatebot#32986) fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.2.2 (renovatebot#32987) feat(managers/circleci): add registryAliases support to circleci manager (renovatebot#32945) refactor: Rename manager result type to `MaybePromise` (renovatebot#32977) chore(deps): lock file maintenance (renovatebot#32982) docs: update references to renovate/renovate (renovatebot#32981) chore(deps): update dependency type-fest to v4.29.1 (renovatebot#32980) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This intends to add support for
registryAliases
to thecircleci
manager.Context
We use an ECR repository that is fronted by a proxy host. The proxy host is responsible for authentication. The vast majority of our image names reference the proxy host repository.
We are now starting to use some of the same images, but addressed through their non-proxied names. this is required for circleci to make use of OIDC for auth to ECR.
The below example should work for the circleci manager.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: