Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Flatten package lookup queue #32930

Merged
merged 9 commits into from
Dec 9, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Dec 5, 2024

Changes

Reorganize task fetching to be performed using a single array of Promise objects

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from viceice and rarkins December 5, 2024 19:07
@zharinov zharinov mentioned this pull request Dec 7, 2024
6 tasks
@zharinov zharinov requested a review from viceice December 8, 2024 15:33
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully oh won't break again 🫣🤞

@rarkins rarkins added this pull request to the merge queue Dec 9, 2024
Merged via the queue into renovatebot:main with commit eb37958 Dec 9, 2024
39 checks passed
@rarkins rarkins deleted the refactor/flatten-lookups-again branch December 9, 2024 17:29
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

SuperSandro2000 added a commit to SuperSandro2000/renovate that referenced this pull request Dec 10, 2024
* upstream/main: (57 commits)
  feat(mix): handle hex package aliases (renovatebot#32984)
  feat(preset): Add modules to Jackson monorepo group (renovatebot#32997)
  docs(nuget): add info about nested nuget ignorePaths (renovatebot#33020)
  chore(deps): update github/codeql-action action to v3.27.7 (renovatebot#33018)
  docs: remove app secrets deprecation date (renovatebot#33010)
  docs: added Renovate Version info to Mend-hosted Apps config page (renovatebot#32917)
  feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.18.0 (renovatebot#33002)
  chore(deps): update dependency type-fest to v4.30.0 (renovatebot#33001)
  refactor(maven): Unified result type for http fetch (renovatebot#32813)
  feat(deps): update ghcr.io/renovatebot/base-image docker tag to v9.17.0 (renovatebot#32993)
  refactor: Flatten package lookup queue (renovatebot#32930)
  chore(deps): update dependency pdm to v2.22.0 (renovatebot#32990)
  chore(deps): update ghcr.io/containerbase/devcontainer docker tag to v13.2.2 (renovatebot#32989)
  chore(deps): update dependency renovatebot/github-action to v41.0.6 (renovatebot#32986)
  fix(deps): update ghcr.io/containerbase/sidecar docker tag to v13.2.2 (renovatebot#32987)
  feat(managers/circleci): add registryAliases support to circleci manager (renovatebot#32945)
  refactor: Rename manager result type to `MaybePromise` (renovatebot#32977)
  chore(deps): lock file maintenance (renovatebot#32982)
  docs: update references to renovate/renovate (renovatebot#32981)
  chore(deps): update dependency type-fest to v4.29.1 (renovatebot#32980)
  ...
@florianmutter
Copy link

Seems to have broken renovate for us. See #30906 (reply in thread)

@viceice viceice added the regression Issue about a regression bug, or the PR caused it label Dec 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue about a regression bug, or the PR caused it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: separate lookup from filter+decide stages
5 participants