Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from cjs to esm #9890

Open
viceice opened this issue May 6, 2021 · 8 comments
Open

Migrate from cjs to esm #9890

viceice opened this issue May 6, 2021 · 8 comments
Assignees
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)

Comments

@viceice
Copy link
Member

viceice commented May 6, 2021

What would you like Renovate to be able to do?
As more and more dependencies are only available as esm we should also start transitioning to esm.

Full esm is supported since node v12.22, v14 has no stable esm

Did you already have any implementation ideas?

  1. First start publishing renovate as cjs and esm, so downstream projects can start testing esm too.
  2. Remove cjs from renovate

Blocker

@viceice viceice added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement labels May 6, 2021
@viceice viceice changed the title Switch from cjs to esm Migrate from cjs to esm May 6, 2021
@viceice
Copy link
Member Author

viceice commented May 6, 2021

@viceice
Copy link
Member Author

viceice commented May 6, 2021

v14 is esm stable too, but docs update not yet released. So will probably come with v14.17.0.

ref: nodejs/node#38409 nodejs/node#38480 nodejs/node#37719 nodejs/node#35781 nodejs/node@c1af593

@viceice viceice added the breaking Breaking change, requires major version bump label May 6, 2021
@thernstig
Copy link

Full esm is supported since node v12.22, v14 has no stable esm

I just happened to stumble upon this, and wanted to be a nice citizen 😄

v14 does have stable ESM support, that is just a bug in the docs. See nodejs/node#38409

@viceice viceice mentioned this issue May 26, 2021
34 tasks
@voxpelli
Copy link

voxpelli commented Aug 7, 2021

Was this solved by #9887 or additional work needed? Found some comments in #11133 around ESM that confused me. Is ESM modules considered not usable by Renovate yet or?

@viceice
Copy link
Member Author

viceice commented Aug 7, 2021

See description of issue, this is blocked by jest issue.

@HonkingGoose
Copy link
Collaborator

@viceice would having this in Jest be enough to get us going?

jestjs/jest#11818

@viceice
Copy link
Member Author

viceice commented Sep 8, 2021

@viceice would having this in Jest be enough to get us going?

facebook/jest#11818

I don't think so, it's very basic and experimental. Lets wait for more stabillity.

@rarkins
Copy link
Collaborator

rarkins commented Dec 18, 2021

Blocked by #13181

@HonkingGoose HonkingGoose added priority-2-high Bugs impacting wide number of users or very important features and removed priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Aug 20, 2023
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-2-high Bugs impacting wide number of users or very important features labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

5 participants