Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(containerbase): remove circular datasource import #25685

Merged
merged 2 commits into from
Nov 10, 2023
Merged

fix(containerbase): remove circular datasource import #25685

merged 2 commits into from
Nov 10, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Nov 10, 2023 •
edited
Loading

Changes

  • this helps for esm transition where the current implementation causes errors

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor November 10, 2023 08:15
@viceice viceice marked this pull request as draft November 10, 2023 08:20
@viceice viceice marked this pull request as ready for review November 10, 2023 08:34
@viceice viceice added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 7d2a301 Nov 10, 2023
36 of 49 checks passed
@viceice viceice deleted the fix/containerbase-circular-dependency branch November 10, 2023 08:47
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.54.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@secustor secustor secustor approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viceice @renovate-release @secustor