feat: add git lfs admin option #10748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @fgblomqvist |
|
@rarkins I think this can be a breaking for some users, if they use git-lfs. Should we enable it by default to not break? or auto enable with a warning when |
HonkingGoose
suggested changes
Jul 7, 2021
HonkingGoose
reviewed
Jul 7, 2021
HonkingGoose
previously approved these changes
Jul 7, 2021
fgblomqvist
reviewed
Jul 11, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
force-pushed
the
feat/supress-lfs-pull
branch
from
d8fbd37
to
bebde38
Compare
|
I've now implemented all required configuration for git-lfs to work. It's also enabled by default so for most people it's a non breaking. It's only breaking for self-hosted users who need to override the |
HonkingGoose
suggested changes
Jul 30, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
suggested changes
Aug 12, 2021
docs/usage/configuration-options.md
Outdated
|
|
||
| Ignore the default project level approval(s), so that Renovate bot can automerge its merge requests, without needing approval(s). | ||
| Under the hood, it creates a MR-level approval rule where `approvals_required` is set to `0`. | ||
| This option works only when `automerge=true`, `automergeType=pr` and `gitLabAutomerge=true`. |
There was a problem hiding this comment.
Suggested change
| This option works only when `automerge=true`, `automergeType=pr` and `gitLabAutomerge=true`. | |
| To use `gitLabIgnoreApprovals` you need to set `automerge=true`, `automergeType=pr` and `gitLabAutomerge=true`. |
Maybe this is clearer?
|
@viceice should we close this for now? |
|
No, i like to move this forward. |
|
Is there a chance for renovate to support git-lfs eventually? |
|
Closing due to staleness |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This add a git lfs admin option, which is disabled by default. It suppress pulling lfs objects on clone / fetch / pull.
Context:
this is a preparation for #6842
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: