-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding GitRepository resource support in flux #18782
feat: adding GitRepository resource support in flux #18782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some documentation improvements.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
I dont know why the re-request features dismiss the other reviewers, forgive me for this. |
the git push has dismissed the review 😉 |
needs deconfliction |
@viceice the main branch does not pass the linting step
I fixed the conflicts locally but these errors have been inherited from main to my branch when I merged main into it. Should I push my code? |
@5cat you need to run yarn install after merge, main is ok https://github.com/renovatebot/renovate/actions/runs/3468750253 |
@viceice any chance of another review or merge if all good? I have expanded on these changes for |
Thank you @viceice @rarkins and @HonkingGoose For your help in this pull request. |
Thank you for the kind words! I'm happy to improve the docs! 🙂 |
🎉 This PR is included in version 34.30.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Changes
flux
manager now can consumeGitRepository
resources and update basedcommit
ortag
keysContext
Closes #18781
This is also related to #12139 (comment)
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: