Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding GitRepository resource support in flux #18782

Merged
merged 22 commits into from
Nov 21, 2022

Conversation

5cat
Copy link
Contributor

@5cat 5cat commented Nov 6, 2022

Changes

flux manager now can consume GitRepository resources and update based commit or tag keys

Context

Closes #18781
This is also related to #12139 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/modules/manager/flux/types.ts Outdated Show resolved Hide resolved
@5cat 5cat requested a review from viceice November 7, 2022 08:03
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation improvements.

lib/modules/manager/flux/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/flux/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/flux/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/flux/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/flux/readme.md Outdated Show resolved Hide resolved
5cat and others added 5 commits November 7, 2022 08:50
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
@5cat 5cat requested a review from viceice November 8, 2022 17:21
rarkins
rarkins previously approved these changes Nov 9, 2022
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
@5cat 5cat requested review from viceice and rarkins and removed request for viceice and rarkins November 10, 2022 10:37
@5cat
Copy link
Contributor Author

5cat commented Nov 10, 2022

I dont know why the re-request features dismiss the other reviewers, forgive me for this.

@viceice
Copy link
Member

viceice commented Nov 10, 2022

I dont know why the re-request features dismiss the other reviewers, forgive me for this.

the git push has dismissed the review 😉

@5cat 5cat requested a review from viceice November 10, 2022 14:01
viceice
viceice previously approved these changes Nov 14, 2022
@5cat 5cat requested a review from rarkins November 14, 2022 07:16
@viceice
Copy link
Member

viceice commented Nov 15, 2022

needs deconfliction

@5cat
Copy link
Contributor Author

5cat commented Nov 15, 2022

@viceice the main branch does not pass the linting step

$ run-s eslint-fix prettier-fix markdown-lint-fix
$ eslint --cache --fix . --report-unused-disable-directives

/usr/src/app/lib/modules/manager/flux/extract.spec.ts
  1:27  error  Unable to resolve path to module 'common-tags'  import/no-unresolved

/usr/src/app/lib/modules/manager/gomod/artifacts.spec.ts
  1:27  error  Unable to resolve path to module 'common-tags'  import/no-unresolved

/usr/src/app/lib/modules/manager/hermit/update.spec.ts
   1:27  error  Unable to resolve path to module 'common-tags'     import/no-unresolved
  12:27  error  Invalid type "any" of template literal expression  @typescript-eslint/restrict-template-expressions
  22:27  error  Invalid type "any" of template literal expression  @typescript-eslint/restrict-template-expressions

/usr/src/app/lib/modules/manager/mint/extract.spec.ts
  1:27  error  Unable to resolve path to module 'common-tags'  import/no-unresolved

/usr/src/app/lib/modules/manager/terraform/extract.spec.ts
  1:27  error  Unable to resolve path to module 'common-tags'  import/no-unresolved

/usr/src/app/lib/modules/manager/tflint-plugin/extract.spec.ts
  1:27  error  Unable to resolve path to module 'common-tags'  import/no-unresolved

/usr/src/app/lib/util/git/errors.spec.ts
  1:27  error  Unable to resolve path to module 'common-tags'  import/no-unresolved

/usr/src/app/lib/util/http/github.spec.ts
  1:27  error  Unable to resolve path to module 'common-tags'  import/no-unresolved

/usr/src/app/lib/util/markdown.spec.ts
   1:27  error  Unable to resolve path to module 'common-tags'                                          import/no-unresolved
  21:7   error  Operands of '+' operation with any is possible only with string, number, bigint or any  @typescript-eslint/restrict-plus-operands

✖ 12 problems (12 errors, 0 warnings)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "eslint-fix" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I fixed the conflicts locally but these errors have been inherited from main to my branch when I merged main into it. Should I push my code?

@viceice
Copy link
Member

viceice commented Nov 15, 2022

@5cat you need to run yarn install after merge, main is ok

https://github.com/renovatebot/renovate/actions/runs/3468750253

@rarkins rarkins requested a review from viceice November 16, 2022 05:17
@onedr0p
Copy link
Contributor

onedr0p commented Nov 21, 2022

@viceice any chance of another review or merge if all good? I have expanded on these changes for OCIRepository and HelmRepository OCI and I have those changes ready to go. I don't mind waiting just poking a bit, thanks!

@viceice viceice enabled auto-merge (squash) November 21, 2022 22:10
@viceice viceice merged commit e68419d into renovatebot:main Nov 21, 2022
@5cat
Copy link
Contributor Author

5cat commented Nov 21, 2022

Thank you @viceice @rarkins and @HonkingGoose For your help in this pull request.
I always thought about a tool that auto-update my dependencies that is not hard dependent on github and was almost about to write my own until I saw this project and instead wanted to contribute to it with the features I needed.
You are awesome thank you for your continues support.

@HonkingGoose
Copy link
Collaborator

Thank you for the kind words! I'm happy to improve the docs! 🙂

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 34.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@heatherleeann
Copy link

Changes

flux manager now can consume GitRepository resources and update based commit or tag keys

Context

Closes #18781
This is also related to #12139 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for GitRepository for flux manager
7 participants