Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bazel datasource #21733

Merged
merged 26 commits into from
Apr 25, 2023
Merged

feat: add bazel datasource #21733

merged 26 commits into from
Apr 25, 2023

Conversation

cgrindel
Copy link
Contributor

Changes

Add bazel-registry datasource.

Context

Related to #13658.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/modules/datasource/bazel-registry/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/bazel-registry/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/bazel-registry/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/bazel-registry/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/bazel-registry/readme.md Outdated Show resolved Hide resolved
lib/modules/datasource/bazel-registry/index.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Apr 22, 2023

@zharinov would you recommend zod validation be added?

@zharinov
Copy link
Collaborator

Oh yes, schema+transform should work great here

@zharinov
Copy link
Collaborator

@cgrindel cgrindel requested a review from rarkins April 22, 2023 19:07
@cgrindel cgrindel requested review from viceice and secustor April 24, 2023 18:57
@secustor secustor changed the title feat: add bazel-registry datasource feat: add bazel datasource Apr 24, 2023
lib/modules/datasource/bazel/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/bazel/readme.md Outdated Show resolved Hide resolved
lib/modules/datasource/bazel/index.ts Outdated Show resolved Hide resolved
@cgrindel cgrindel requested a review from secustor April 25, 2023 14:58
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/datasource/bazel/index.ts Outdated Show resolved Hide resolved
@cgrindel cgrindel requested a review from viceice April 25, 2023 17:41
@secustor
Copy link
Collaborator

@cgrindel
Copy link
Contributor Author

@secustor Sorry. I thought that rule was regarding updating a commit and force pushing. How do you prefer that I bring in the latest changes from main? I have been doing a rebase, then pushing to the branch.

@cgrindel
Copy link
Contributor Author

@secustor I just re-read the passage. I will use the 'Update branch' button. Again, sorry about that.

lib/modules/datasource/bazel/index.ts Outdated Show resolved Hide resolved
@cgrindel cgrindel requested a review from secustor April 25, 2023 19:28
@rarkins rarkins added this pull request to the merge queue Apr 25, 2023
Merged via the queue into renovatebot:main with commit 7f4c8eb Apr 25, 2023
@cgrindel cgrindel deleted the feat/13658_bazel_registry_datasource_new branch April 25, 2023 20:40
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mjunker pushed a commit to mjunker/renovate that referenced this pull request May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants