test: time difference with time zone #22782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By testing without a time zone, the original test worked differently based on the local time zone of the machine running the test. This is presumably because of a summer time/winter time difference, because changing the date from `2020-10-10` to `2020-05-10` without setting the time zone also makes the test pass on my machine (Pacific/Auckland time zone).
zharinov
approved these changes
Jun 15, 2023
viceice
approved these changes
Jun 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
viceice
changed the title
viceice
changed the title
|
🎉 This PR is included in version 35.121.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
zharinov
pushed a commit
to zharinov/renovate
that referenced
this pull request
Jun 16, 2023
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
None.
Context
By testing without a time zone, the original test worked differently based on the local time zone of the machine running the test. This is presumably because of a summer time/winter time difference, because changing the date from
2020-10-10to2020-05-10without setting the time zone also makes the test pass on my machine (Pacific/Auckland time zone).Documentation
How I've tested my work
I have verified these changes via: