fix(config)!: Use depNameSanitized in branch name for vulnerability alerts
#25166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the santaised dep name for branch creation, this ensure that the branch does not have special characters which could cause issues with other services.
viceice
previously approved these changes
Oct 12, 2023
viceice
changed the title
viceice
changed the title
depNameSanitized in branch name for vulnerability alerts
|
This looks like the right thing to do, but the question is about disruption to users. Any existing Remediation PR with a special character will be autoclosed and recreated. |
viceice
reviewed
Oct 12, 2023
|
I don't think that part matters. I do consider it a fix! |
|
sure, let's do a fix with major bump |
viceice
changed the title
depNameSanitized in branch name for vulnerability alertsdepNameSanitized in branch name for vulnerability alerts
rarkins
requested changes
Oct 23, 2023
rarkins
force-pushed
the
v38
branch
6 times, most recently
from
fdc9cbb
to
6717725
Compare
rarkins
approved these changes
Apr 14, 2024
viceice
approved these changes
Apr 14, 2024
rarkins
pushed a commit
that referenced
this pull request
Apr 14, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
Apr 20, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
Apr 21, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
Apr 21, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
Apr 22, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
Apr 26, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
Apr 29, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
May 3, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
May 4, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
May 5, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
May 6, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
rarkins
pushed a commit
that referenced
this pull request
May 11, 2024
… alerts (#25166) Use sanitized depName in vulnerability/remediation branches instead of raw depName. This will result in some open remediation branches being autoclosed and replaced for ecosystems like go in particular which have special characters in depNames. BREAKING CHANGE: Branch names for remediation will be sanitized to exclude special characters, potentially resulting in some autoclosing/replacing of existing PRs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use the santaised dep name for branch creation, this ensure that the branch does not have special characters which could cause issues with other services.
go-golang-org/x/net-vulnerabilityshould bego-golang-org-x-net-vulnerabilityContext
We discovered this issue after the branch name was picked up by a downstream build and caused an error due to the unexpected
/.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: