-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templating): adds encodeBase64 handlebars helper #26197
Merged
viceice
merged 7 commits into
renovatebot:main
from
moltar:feat/handlebars-helper-encode-base64
Dec 11, 2023
Merged
feat(templating): adds encodeBase64 handlebars helper #26197
viceice
merged 7 commits into
renovatebot:main
from
moltar:feat/handlebars-helper-encode-base64
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
previously approved these changes
Dec 8, 2023
rarkins
changed the title
feat: adds encodeBase64 handlebars helper
feat(templating): adds encodeBase64 handlebars helper
Dec 8, 2023
secustor
previously approved these changes
Dec 8, 2023
viceice
reviewed
Dec 8, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
previously approved these changes
Dec 8, 2023
Added extra tests for nullish coalescing to fix coverage. |
rarkins
approved these changes
Dec 11, 2023
viceice
approved these changes
Dec 11, 2023
🎉 This PR is included in version 37.90.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a
encodeBase64
handlebars helper that encodes a string to Base64.Context
When using template variables with strings that may contain special characters, it makes it more
difficult to use with commands.
Consider this example:
The value of the
body
variable contains the full changelog, which may contain anything.Renovate will replace the variable, before the command runs, and thus it will result in a command:
But if the
body
variable contains a double quote, the command will fail:By encoding the values in Base64, we can avoid this issue:
Related discussion: #26175
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: