Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-runners): add macOS 12 large and 13 large #27229

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Try to add macOS 12 large, and macOS 13 large runners to our code

Context

It looks like we're missing the large variant for macOS 12 and 13. We should probably add those variants to our code, because the official readme mentions those. 1

Also read the discussion here:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Footnotes

  1. actions/runner-images readme, available images

@HonkingGoose HonkingGoose marked this pull request as ready for review February 12, 2024 10:02
lib/modules/datasource/github-runners/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/github-runners/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/github-runners/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/github-runners/index.ts Outdated Show resolved Hide resolved
HonkingGoose and others added 4 commits February 12, 2024 13:45
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add isDeprecated to all known unsupported and deprecated versions.

isDeprecated?: boolean;

@secustor secustor added this pull request to the merge queue Feb 12, 2024
Merged via the queue into renovatebot:main with commit 9eb7a08 Feb 12, 2024
34 checks passed
@HonkingGoose HonkingGoose deleted the patch-2 branch February 12, 2024 21:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.186.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose
Copy link
Collaborator Author

we should add isDeprecated to all known unsupported and deprecated versions.

isDeprecated?: boolean;

See issue:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants