-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Flatten update lookup tasks #27369
Conversation
This one should be tested well |
I haven't formalized my thoughts yet, but here we may want the single queue to be cancelable. Because, even we get |
@rarkins Could you provide a hint of how lookup error handling should work? Given we have flat list of lookup tasks performed concurrently, it's not clear how to deal with errors:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rate limiting first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️ needs extensive testing
@zharinov needs deconflicting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️
🎉 This issue has been resolved in version 38.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This causes OOM with repo cache and regex managers, so it's getting reverted. |
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: