Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): change onboardingNoDeps from boolean to enum #28133

Merged
merged 15 commits into from
Apr 14, 2024
Merged

feat(config): change onboardingNoDeps from boolean to enum #28133

merged 15 commits into from
Apr 14, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Change type of admin only config option onboardingNoDeps from boolean to enum
  • Switch the value of onboardingNoDeps to enabled if autodiscover is set false

Context

Closes: #28101

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs config migration too

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
rarkins and others added 4 commits March 27, 2024 04:51
@rarkins
fix(config): globalExtends merge default (renovatebot#28145)
d9ba74d 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes renovatebot#28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
@RahulGautamSingh @rarkins
Update docs/usage/self-hosted-configuration.md
a8cfb50 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@RahulGautamSingh
update docs
a4e8452
@RahulGautamSingh
add migration code
475b650
rarkins
rarkins requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, changed my mind! Let's just release this with v38 and with no migration - just a breaking change notification. Otherwise we also need to massage env and CLI params too. Please remove the migrations!

@rarkins rarkins changed the base branch from main to v38 March 27, 2024 12:08
rarkins and others added 2 commits April 13, 2024 10:53
@rarkins
fix(config): globalExtends merge default (renovatebot#28145)
fb013c9 
Previously, config from globalExtends was incorrectly merged _after_ other global config. This meant for example that packageRules in a config.js could not override packageRules from within globalExtends, because they were applied after. Now, globalExtends content will be merged first, and remaining global config merged second.

Fixes renovatebot#28131

BREAKING CHANGE: order of globalExtends resolution is changed so that it is applied first and remaining global config takes precedence.
@secustor @viceice @rarkins
feat(manager/pep621): allow auto grouping of dependencies in differen…
2da2fde 
…t groups (renovatebot#28193)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins
rarkins previously approved these changes Apr 13, 2024
View reviewed changes
@rarkins rarkins changed the title feat(config/onboardingNoDeps): change type from boolean to enum feat(config): change onboardingNoDeps from boolean to enum Apr 13, 2024
@rarkins rarkins requested a review from viceice April 13, 2024 09:15
viceice
viceice reviewed Apr 13, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no migration?

@rarkins
Copy link
Collaborator

rarkins commented Apr 13, 2024

Thought we could do it in a major

@RahulGautamSingh RahulGautamSingh dismissed rarkins’s stale review April 14, 2024 07:39

The merge-base changed after approval.

@rarkins rarkins requested a review from viceice April 14, 2024 08:43
@rarkins rarkins enabled auto-merge (squash) April 14, 2024 08:45
viceice
viceice requested changes Apr 14, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated changes

lib/modules/manager/pep621/extract.spec.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice April 14, 2024 13:28
@rarkins rarkins merged commit 7fa65fd into renovatebot:v38 Apr 14, 2024
34 checks passed
rarkins pushed a commit that referenced this pull request Apr 20, 2024
@RahulGautamSingh @rarkins
feat(config): change onboardingNoDeps from boolean to enum (#28133)
d927b87 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request Apr 20, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
858b3ea 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request Apr 21, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
3a03e41 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request Apr 21, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
bc55594 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request Apr 22, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
331a072 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request Apr 26, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
1181466 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request Apr 29, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
adb8fae 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request May 3, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
d759cdf 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request May 4, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
8063a25 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request May 5, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
f0d02a8 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request May 6, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
802d389 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
rarkins pushed a commit that referenced this pull request May 11, 2024
@RahulGautamSingh @rarkins
feat(config)!: change onboardingNoDeps from boolean to enum (#28133)
4755d7c 
Change onboardingNoDeps from boolean to enum, with new default "auto". Auto means that Renovate will continue skipping repos with no dependencies if autodiscover is in use, but onboarding them if they are explicitly specified in a non-autodiscover mode.

Closes #28101

BREAKING CHANGE: onboardingNoDeps changes from boolean to enum. Repositories with no dependencies will be onboarded unless in autodiscover mode.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change onboardingNoDeps to enum, and behavior similar to forkProcessing
5 participants
@RahulGautamSingh @rarkins @viceice @HonkingGoose @secustor