Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): add glasskube packages datasource #29430

Merged

Conversation

kosmoz
Copy link
Contributor

@kosmoz kosmoz commented Jun 4, 2024

Changes

This PR adds a new datasource for updating packages used by the Glasskube package manager.

Context

See #29322

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Disclaimer: I added unit tests to fulfill the coverage goal, but did not test on a real repository because I could not find out how to do that without a matching manager.

Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
lib/modules/datasource/glasskube-packages/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/glasskube-packages/types.ts Outdated Show resolved Hide resolved
lib/modules/datasource/glasskube-packages/index.ts Outdated Show resolved Hide resolved
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz kosmoz requested review from secustor and viceice June 6, 2024 10:11
kosmoz and others added 3 commits June 7, 2024 14:13
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@rarkins rarkins requested review from secustor and viceice June 12, 2024 11:32
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz kosmoz force-pushed the feat/29322-glasskube-packages-datasource branch from 478fdeb to cb6bcac Compare June 12, 2024 11:33
@kosmoz
Copy link
Contributor Author

kosmoz commented Jun 12, 2024

I added the default versioning, as suggested by @secustor (#29322 (comment)).

Unfortunately, I had to force push the branch because GitHub didn't like the way I previously merged the upstream changes. Hope this didn't mess up the reviewer history, since it didn't affect the old commits… 🙃

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz kosmoz requested a review from viceice June 12, 2024 13:53
secustor
secustor previously approved these changes Jun 12, 2024
@rarkins rarkins enabled auto-merge June 12, 2024 17:20
auto-merge was automatically disabled June 14, 2024 13:02

Head branch was pushed to by a user without write access

Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
auto-merge was automatically disabled June 25, 2024 14:13

Head branch was pushed to by a user without write access

@kosmoz kosmoz requested a review from viceice June 25, 2024 14:30
@rarkins rarkins enabled auto-merge June 25, 2024 15:07
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
auto-merge was automatically disabled June 25, 2024 15:23

Head branch was pushed to by a user without write access

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@kosmoz kosmoz requested a review from viceice June 26, 2024 08:22
viceice
viceice previously approved these changes Jun 26, 2024
@secustor
Copy link
Collaborator

Needs prettier run

Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
viceice
viceice previously approved these changes Jun 26, 2024
lib/modules/datasource/glasskube-packages/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@secustor secustor enabled auto-merge June 26, 2024 13:31
@secustor secustor added this pull request to the merge queue Jun 26, 2024
Merged via the queue into renovatebot:main with commit bbde807 Jun 26, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.419.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kosmoz kosmoz deleted the feat/29322-glasskube-packages-datasource branch June 26, 2024 14:09
bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants