Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restrict downgrade checks only to Docker versioning scheme #30105

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jul 9, 2024

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Jul 9, 2024
Merged via the queue into renovatebot:main with commit e12e493 Jul 9, 2024
38 checks passed
@rarkins rarkins deleted the fix/restrict-downgrade-check-to-docker-versioning branch July 9, 2024 17:33
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.426.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice
Copy link
Member

viceice commented Jul 9, 2024

do we now know it's only happening on docker versioning?

@zharinov
Copy link
Collaborator Author

zharinov commented Jul 9, 2024

do we now know it's only happening on docker versioning?

It's not proven, but so far, only Docker-based versions were affected. And we have bunch of weird versioning schemes, which may be affected by our patch, so for now it's reasonable to restrict it only for Docker ones.

@viceice
Copy link
Member

viceice commented Jul 10, 2024

do we now know it's only happening on docker versioning?

It's not proven, but so far, only Docker-based versions were affected. And we have bunch of weird versioning schemes, which may be affected by our patch, so for now it's reasonable to restrict it only for Docker ones.

ok, next time please add this information to the PR description or link to relevant issue or discussion 🙃

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants