Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/orb): retrieve more releases #31165

Conversation

mkniewallner
Copy link
Contributor

Changes

Closes #31164.

Update the GraphQL query that retrieves orb releases from CircleCI to retrieve more items by default.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Ran Renovate with the changes locally against https://github.com/backmarket-oss/renovate-repro-orb-max-items-issue.

We can see that:

  • Renovate GitHub app was only able to detect updates for the orb being less than 10 releases late
  • Local Renovate was able to detect updates for both orbs (the one being more than 10 releases late, the one being less than 10 releases late)

@mkniewallner mkniewallner marked this pull request as ready for review September 2, 2024 16:56
@rarkins rarkins added this pull request to the merge queue Sep 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2024
@rarkins rarkins added this pull request to the merge queue Sep 2, 2024
Merged via the queue into renovatebot:main with commit 08a08ec Sep 2, 2024
55 checks passed
@mkniewallner mkniewallner deleted the fix/retrieve-more-items-orb-datasource branch September 2, 2024 17:40
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.63.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants