Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replacements): add replacements:gradle-wrapper-validation-action #31645

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mueller-ma
Copy link
Contributor

Changes

See Readme at https://github.com/gradle/wrapper-validation-action for more information.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally don't want to do "replacements"
When the change is breaking. An alternative here is to met the user update to v3 and then migrate them

@mueller-ma
Copy link
Contributor Author

Now the user needs to update to version 3 before the replacement happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants