Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(maven): Unified result type for s3 fetch #32814

Merged
merged 6 commits into from
Dec 8, 2024

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from viceice November 29, 2024 19:55
@zharinov zharinov requested a review from rarkins November 29, 2024 20:02
@zharinov zharinov changed the title refactor(maven): Unified result type for s3 protocol fetch refactor(maven): Unified result type for s3 fetch Nov 29, 2024
rarkins
rarkins previously approved these changes Dec 6, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/datasource/maven/util.ts Show resolved Hide resolved
@zharinov zharinov requested a review from viceice December 8, 2024 18:30
@zharinov zharinov marked this pull request as draft December 8, 2024 18:31
@zharinov zharinov marked this pull request as ready for review December 8, 2024 18:31
@zharinov zharinov marked this pull request as draft December 8, 2024 18:38
@zharinov zharinov marked this pull request as ready for review December 8, 2024 18:38
@zharinov zharinov marked this pull request as draft December 8, 2024 19:24
@zharinov zharinov marked this pull request as ready for review December 8, 2024 19:24
@viceice viceice added this pull request to the merge queue Dec 8, 2024
Merged via the queue into renovatebot:main with commit b908402 Dec 8, 2024
74 of 90 checks passed
@viceice viceice deleted the refactor/maven-s3-fetch-result branch December 8, 2024 21:51
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants