Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yarn): yarn v2 yarnrc support #7235

Closed
wants to merge 3 commits into from
Closed

fix(yarn): yarn v2 yarnrc support #7235

wants to merge 3 commits into from

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Sep 9, 2020

Part of #5230

Still doesn't work without manually specifying the yarn compatability (that is coming in a separate PR)

@JamieMagee JamieMagee changed the title fix/yarn v2 yarnrc fix(yarn): yarn v2 yarnrc support Sep 9, 2020
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs test coverage too

lib/manager/npm/post-update/index.ts Show resolved Hide resolved
Comment on lines +58 to +59
'.yarnrc',
'.yarnrc.yml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.yarnrc.yml overrides (takes precedence over) .yarnrc in Yarn 1 (https://git.io/JUcco, #7220 (comment)).

@rarkins rarkins marked this pull request as draft November 24, 2020 09:20
@rarkins rarkins closed this Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants