Fix Cosmos config initialisation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several functions within the Cosmos SDK that make use of a global configuration to fetch the Bech32 prefix for an account. #49 updated the Multichain to set this prefix before each operation that interacts with the Cosmos SDK to allow us to support multiple Cosmos-compatible chains in the future. This has the obvious downside of potentially causing panics if the functions are called concurrently, and due to this we have decided to move away from this in favour of a config initialisation on boot. The downside to this is we cannot easily add support for other Cosmos-compatible chains in the near future because they will all use different prefixes. However, this issue is being tracked in the Cosmos SDK (cosmos/cosmos-sdk#7448) and is aimed to be resolved before the next major release.