Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor signature update to adapt to SWIG generated python #3

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

renukamanavalan
Copy link
Owner

No description provided.

@renukamanavalan renukamanavalan self-assigned this Jun 17, 2022
@@ -155,83 +156,6 @@ T get_config_data(const string key, T def)

const string get_timestamp();

/*
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No logical code change. Code moved into struct.

Copy link
Collaborator

@zbud-msft zbud-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renukamanavalan renukamanavalan merged commit c71e7f0 into syslog_telemetry_shared Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants